[PATCH] D58820: Fix update_mir_test_checks.py to run on python3

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 05:15:31 PST 2019


RKSimon created this revision.
RKSimon added reviewers: gbedwell, MaskRay, lebedev.ri.
Herald added a reviewer: serge-sans-paille.
Herald added a project: LLVM.

Split off from D58817 <https://reviews.llvm.org/D58817>


Repository:
  rL LLVM

https://reviews.llvm.org/D58820

Files:
  utils/update_mir_test_checks.py


Index: utils/update_mir_test_checks.py
===================================================================
--- utils/update_mir_test_checks.py
+++ utils/update_mir_test_checks.py
@@ -62,6 +62,8 @@
         with open(ir) as ir_file:
             stdout = subprocess.check_output('{} {}'.format(self.bin, args),
                                              shell=True, stdin=ir_file)
+            if sys.version_info[0] > 2:
+              stdout = stdout.decode()
             # Fix line endings to unix CR style.
             stdout = stdout.replace('\r\n', '\n')
         return stdout
@@ -408,7 +410,7 @@
     log('Writing {} lines to {}...'.format(len(output_lines), test), verbose)
 
     with open(test, 'wb') as fd:
-        fd.writelines([l + '\n' for l in output_lines])
+        fd.writelines(['{}\n'.format(l).encode('utf-8') for l in output_lines])
 
 
 def main():


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58820.188886.patch
Type: text/x-patch
Size: 894 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190301/47a7fa80/attachment.bin>


More information about the llvm-commits mailing list