[PATCH] D58813: [ARM] Fix select_cc lowering for fp16

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: test/CodeGen/ARM/vsel-fp16.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=armv8a--none-eabi -mattr=+fp-armv8,+fp16,+fullfp16 -float-abi=hard | FileCheck %s
+
----------------
Just for simplicity, can we omit +fp16 here? Or do we actually need it?

For a moment I was wondering if we also need to test this with -fullfp16? I appreciate we are not testing this change anymore, but then remembered we are doing that in fp16-instructions.ll, which also contains some VSEL checks. Perhaps we can move these tests to there, or vice versa, to keep the VSEL tests together?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58813/new/

https://reviews.llvm.org/D58813