[PATCH] D58786: [DebugInfo] Construct nested types on behalf of owner CU

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 01:22:21 PST 2019


evgeny777 added a comment.

> Would it be possible/practical/reasonable to split getOrCreateTypeDIE

I think so, but I thought it's easier to do things this way, because AFAIK:

- DIBaseType and DISubroutineType can't introduce the problem because they're either bound to variable or typedef (DIDerivedType)
- Using type units also isn't problematic because in such case DINodes are not shareable across CUs

Ok, I'll try splitting and see how it goes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58786/new/

https://reviews.llvm.org/D58786





More information about the llvm-commits mailing list