[PATCH] D58750: [DWARF] Make -g with empty assembler source work better.

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 16:04:51 PST 2019


probinson marked 2 inline comments as done.
probinson added inline comments.


================
Comment at: llvm/lib/MC/MCContext.cpp:586
+  if (FileName.consume_front(getCompilationDir()))
+    (void)FileName.consume_front(llvm::sys::path::get_separator());
+  assert(!FileName.empty());
----------------
dblaikie wrote:
> No need for the "(void)" here - this function isn't marked NO_DISCARD or anything liek that, by the looks of it?
No, it's not. Wasn't entirely sure what the criteria were. I'll remove this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58750/new/

https://reviews.llvm.org/D58750





More information about the llvm-commits mailing list