[PATCH] D58765: [sanitizers] Don't use Windows Trace Logging on MinGW

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 15:21:27 PST 2019


rnk added a comment.

> Should this be factored into some general define in some header (which one?) like SANITIZER_WIN_TRACE or so, to avoid duplicating the condition all over the place?

I just noticed that this breaks clang-cl builds of asan because clang-cl doesn't support some weird pre-processor patterns used by TraceLoggingProvider.h:
https://bugs.llvm.org/show_bug.cgi?id=32021

So, I think we should go ahead and make SANITIZER_WIN_TRACE and add `defined(__clang__)` to the list of conditions. I think the simplest check is probably `#if defined(_MSC_VER) && !defined(__clang__)` because that rules out mingw.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58765/new/

https://reviews.llvm.org/D58765





More information about the llvm-commits mailing list