[PATCH] D58795: ELF: Write .eh_frame_hdr explicitly after writing .eh_frame.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 14:58:46 PST 2019


pcc marked an inline comment as done.
pcc added inline comments.


================
Comment at: lld/ELF/OutputSections.h:128
 struct Out {
+  static uint8_t *Base;
   static uint8_t First;
----------------
ruiu wrote:
> At first I thought that this is a base address or something, but turned out this is just a pointer to the beginning of a buffer. Maybe `BufferStart` is a better name?
Makes sense, done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58795/new/

https://reviews.llvm.org/D58795





More information about the llvm-commits mailing list