[PATCH] D58770: [LSR] Attempt to increase the accuracy of LSR's setup cost

[Brendon Cahoon via Phabricator via llvm-commits]

bcahoon added a comment.

Hi David,

The Hexagon related test changes look good to me. Neither of these test changes indicate that your patch causes any problems. In swp-carried-1.ll, the hardware loop is no longer generated. In this case, I should just change the test to use a real value for the initial loop induction variable, %v4, instead of undef, say 0 (I can do that later).  In swp-epilog-phi5.ll, the compiler is now generating an extra, innermost, hardware loop, so that's why the test changes from loop0 to loop1.  The loop1/endloop1 instructions represent an outer hardware loop.  This is another test that I should fix since subtle changes in the generated code cause the compiler to create/not create a hardware loop.  Thanks for letting us know about the changes to the Hexagon tests.   Let me know if you have any further questions.

Thanks,
Brendon


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58770/new/

https://reviews.llvm.org/D58770