[PATCH] D58787: [ProfileData] Sort ProfilingData by hash

[Jonas Hahnfeld via Phabricator via llvm-commits]

Hahnfeld marked 2 inline comments as done.
Hahnfeld added a comment.

I don't care how this is solved, but it needs to be solved! And it's not getting easier with everyone saying something different



================
Comment at: llvm/include/llvm/ProfileData/InstrProfWriter.h:36
 public:
-  using ProfilingData = SmallDenseMap<uint64_t, InstrProfRecord>;
+  using ProfilingData = std::map<uint64_t, InstrProfRecord>;
   enum ProfKind { PF_Unknown = 0, PF_FE, PF_IRLevel };
----------------
mgrang wrote:
> I think llvm prefers not to rely on external/STL containers. I would use a MapVector here.
```
$ git grep "std::map" -- llvm/include/ llvm/lib/ | wc -l
426
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58787/new/

https://reviews.llvm.org/D58787