[llvm] r355110 - [Tests] Strengthen LICM test corpus to show alignment striping

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 10:08:04 PST 2019


Author: reames
Date: Thu Feb 28 10:08:04 2019
New Revision: 355110

URL: http://llvm.org/viewvc/llvm-project?rev=355110&view=rev
Log:
[Tests] Strengthen LICM test corpus to show alignment striping

Doing scalar promotion w/o being able to prove the alignment of the hoisted load or sunk store is a bug.  Update tests to actually show the alignment so that impact of the patch which fixes this can be seen.


Modified:
    llvm/trunk/test/Transforms/LICM/promote-tls.ll
    llvm/trunk/test/Transforms/LICM/scalar-promote-unwind.ll

Modified: llvm/trunk/test/Transforms/LICM/promote-tls.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/LICM/promote-tls.ll?rev=355110&r1=355109&r2=355110&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/LICM/promote-tls.ll (original)
+++ llvm/trunk/test/Transforms/LICM/promote-tls.ll Thu Feb 28 10:08:04 2019
@@ -21,6 +21,8 @@ entry:
   br label %for.body.lr.ph
 
 for.body.lr.ph:                                   ; preds = %entry
+; CHECK-LABEL: for.body.lr.ph:
+; CHECK-NEXT: %addr.promoted = load i32, i32* %addr, align 1
   br label %for.header
 
 for.header:
@@ -59,6 +61,8 @@ entry:
   br label %for.body.lr.ph
 
 for.body.lr.ph:                                   ; preds = %entry
+; CHECK-LABEL: for.body.lr.ph:
+; CHECK-NEXT: %addr.promoted = load i32, i32* %addr, align 1
   br label %for.header
 
 for.header:

Modified: llvm/trunk/test/Transforms/LICM/scalar-promote-unwind.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/LICM/scalar-promote-unwind.ll?rev=355110&r1=355109&r2=355110&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/LICM/scalar-promote-unwind.ll (original)
+++ llvm/trunk/test/Transforms/LICM/scalar-promote-unwind.ll Thu Feb 28 10:08:04 2019
@@ -67,6 +67,32 @@ for.cond.cleanup:
   ret void
 }
 
+define void @test3(i1 zeroext %y) uwtable {
+; CHECK-LABEL: @test3
+entry:
+; CHECK-LABEL: entry:
+; CHECK-NEXT:  %a = alloca i32
+; CHECK-NEXT:  %a.promoted = load i32, i32* %a, align 1
+  %a = alloca i32
+  br label %for.body
+
+for.body:
+  %i.03 = phi i32 [ 0, %entry ], [ %inc, %for.body ]
+  %0 = load i32, i32* %a, align 4
+  %add = add nsw i32 %0, 1
+  tail call void @f()
+  store i32 %add, i32* %a, align 4
+  %inc = add nuw nsw i32 %i.03, 1
+  %exitcond = icmp eq i32 %inc, 10000
+  br i1 %exitcond, label %for.cond.cleanup, label %for.body
+
+for.cond.cleanup:
+; CHECK-LABEL: for.cond.cleanup:
+; CHECK: store i32 %add.lcssa, i32* %a, align 1
+; CHECK-NEXT: ret void
+  ret void
+}
+
 @_ZTIi = external constant i8*
 
 ; In this test, the loop is within a try block. There is an explicit unwind edge out of the loop.




More information about the llvm-commits mailing list