[PATCH] D58787: [ProfileData] Sort ProfilingData by hash

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 09:32:01 PST 2019


I don' t have issue with that patch, but you need rsmith@ to take a closer
look at it.

On Thu, Feb 28, 2019 at 9:18 AM Jonas Hahnfeld via Phabricator <
reviews at reviews.llvm.org> wrote:

> Hahnfeld added a comment.
>
> In D58787#1413869 <https://reviews.llvm.org/D58787#1413869>, @davidxl
> wrote:
>
> > The secondary map 'ProfileData' is needed occasionally (to use cfg
> hash).  doing sorting with std::map is not needed strictly speaking, but it
> has the nice property of having fixed order.
>
>
> Yeah I know, the other approach is making the test resilient against such
> changes in ordering: D58385 <https://reviews.llvm.org/D58385>
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D58787/new/
>
> https://reviews.llvm.org/D58787
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190228/ef8d870f/attachment.html>


More information about the llvm-commits mailing list