[PATCH] D58070: [DAG] Remember nodes added to the worklist for pruning.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 09:08:27 PST 2019


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/pr39478.ll:10
 ; CHECK:       # %bb.0: # %entry
-; CHECK-NEXT:    lwz 3, 0(3)
-; CHECK-NEXT:    stb 3, 0(3)
 ; CHECK-NEXT:    blr
 entry:
----------------
niravd wrote:
> RKSimon wrote:
> > This looks like an over-reduced test?
> With the improved pruning, we are able to narrow the load to 1 byte which as both the load and store are to undef cancel out the both ops. 
I'm hitting issues with this test in D58017 as well, but I'd prefer to see it still do what its supposed to (even if its driving me nuts at the moment....)

IMO we need to replace the undef pointers so it still tests https://bugs.llvm.org/show_bug.cgi?id=39478


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58070/new/

https://reviews.llvm.org/D58070





More information about the llvm-commits mailing list