[PATCH] D58787: [ProfileData] Sort ProfilingData by hash

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 09:08:26 PST 2019


Hahnfeld added a comment.

In D58787#1413840 <https://reviews.llvm.org/D58787#1413840>, @lebedev.ri wrote:

> Have you considered only imposing the ordering/sorting where it matters,
>  i.e. i think where `FunctionData` is used in `InstrProfWriter::writeImpl()` and `InstrProfWriter::writeText()`?


No. But AFAICS you cannot sort a `SmallDenseMap`, so we'd need to create another `std::map` just for sorting?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58787/new/

https://reviews.llvm.org/D58787





More information about the llvm-commits mailing list