[PATCH] D58633: [InstCombine] remove one-use restriction for icmp+add constant fold

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

It looks like this was added on purpose way back in https://reviews.llvm.org/rL16473. That was so long ago that everything will have changed since then, but have you run any benchmarks for this?

I agree that LSR should //probably// be turning this back into a cmp based on the inc in any loop backedges. But I'm not sure it will do that equally well for all backends. And changing the canonical form of a loop backedge is quite a big change :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58633/new/

https://reviews.llvm.org/D58633