[PATCH] D58762: [BinaryFormat] Add DT_USED tag into dynamic section.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 02:06:53 PST 2019


jhenderson added a comment.

Hmmm... I'm not sure about this. The code and test look fine, but I'm wondering if we should even support this? (I have similar concerns re. DT_AUXILIARY and DT_FILTER by the way, but they're already recognised by LLVM). In particular, this is in the processor-specific tag range, so could conflict with the value some developers have used for their own processor-specific tag. Some questions before I give this the thumbs up:

1. Do GNU objdump and readelf recognise this flag?
2. Do you know of any actual users of this tag?
3. Is there documentation for these tags anywhere other than the Oracle/Sun documentation? I'm not talking about code examples here by the way.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58762/new/

https://reviews.llvm.org/D58762





More information about the llvm-commits mailing list