[PATCH] D58028: Always compare C++ typeinfo (based on libstdc++ implementation).

Wed Feb 27 16:04:06 PST 2019

Bigcheese requested changes to this revision.
Bigcheese added a comment.
This revision now requires changes to proceed.

Thanks for the update.  This still looks incorrect in that `SANITIZER_NON_UNIQUE_TYPEINFO` should be 1 on `defined(__arm64__) && SANITIZER_IOS` and 0 otherwise on `SANITIZER_MAC`.

I believe the following is correct.

  #if SANITIZER_MAC && !(defined(__arm64__) && SANITIZER_IOS)
  # define SANITIZER_NON_UNIQUE_TYPEINFO 0
  #else
  # define SANITIZER_NON_UNIQUE_TYPEINFO 1
  #endif

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58028/new/

https://reviews.llvm.org/D58028