[PATCH] D58741: [NFC][Sanitizer] Add new BufferedStackTrace::Unwind API

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 27 15:00:12 PST 2019


yln created this revision.
yln added a reviewer: vitalybuka.
Herald added subscribers: llvm-commits, Sanitizers, kubamracek.
Herald added a reviewer: jfb.
Herald added projects: Sanitizers, LLVM.

Add new Unwind API. This is the final envisioned API with the correct
abstraction level. It hides/slow fast unwinder selection from the caller
and doesn't take any arguments that would leak that abstraction (i.e.,
arguments like stack_top/stack_bottom).

GetStackTrace will become an implementation detail (private method) of
the BufferedStackTrace class.

Let's postpone cleaning up the individual GetStackTrace implementations
until the surrounding code is in its final state.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D58741

Files:
  compiler-rt/lib/asan/asan_errors.cc
  compiler-rt/lib/asan/asan_stack.h
  compiler-rt/lib/hwasan/hwasan.h
  compiler-rt/lib/hwasan/hwasan_linux.cc
  compiler-rt/lib/lsan/lsan.cc
  compiler-rt/lib/lsan/lsan.h
  compiler-rt/lib/msan/msan.cc
  compiler-rt/lib/msan/msan.h
  compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.h
  compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cc
  compiler-rt/lib/tsan/rtl/tsan_rtl.cc
  compiler-rt/lib/tsan/rtl/tsan_rtl_report.cc
  compiler-rt/lib/ubsan/ubsan_diag.cc
  compiler-rt/lib/ubsan/ubsan_diag_standalone.cc
  compiler-rt/lib/ubsan/ubsan_signals_standalone.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58741.188633.patch
Type: text/x-patch
Size: 16907 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190227/b705889b/attachment.bin>


More information about the llvm-commits mailing list