[PATCH] D58737: [InstrProf] Use separate comdat group for data and counters

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 27 14:51:09 PST 2019


xur added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:756
+      // For COFF, the comdat group name must be the name of a symbol in the
+      // group. Use the counter variable name.
+      Cmdt = M->getOrInsertComdat(
----------------
So with the patch, COFF and ELF have the same way of naming. Can we simplify the code by hosting the common code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58737/new/

https://reviews.llvm.org/D58737





More information about the llvm-commits mailing list