[PATCH] D58184: [scudo][standalone] Introduce platform specific code & mutexes

[Brian Rzycki via Phabricator via llvm-commits]

brzycki added a comment.

`append_list_if(COMPILER_RT_HAS_LIBRT -lrt LINK_FLAGS)` did not work, nor did `list(APPEND LINK_FLAGS -lrt)` for RHEL 6.7.

I noticed this code failure path is a spawned cmake instance within the Ninja build. It starts by trying to build libfuzzer support for libcxx:

  [1225/3976] cd /tmp/tmp.DxqFrKPwdj/build/llvm/projects/compiler-rt/lib/fuzzer/libcxx_fuzzer_x86_64-bins && /tools/build/cmake-3.13.4/bin/cmake -DCMAKE_SHARED_LINKER_FLAGS=
  -DCMAKE_MODULE_LINKER_FLAGS= -DCMAKE_EXE_LINKER_FLAGS= -DCMAKE_INSTALL_PREFIX=/tmp/bmr/4 -DCMAKE_MAKE_PROGRAM=/tools/build/ninja-1.9.0/ninja -DCMAKE_LINKER=/usr/bin/ld -DCM
  AKE_AR=/usr/bin/ar -DCMAKE_RANLIB=/usr/bin/ranlib -DCMAKE_NM=/usr/bin/nm -DCMAKE_OBJCOPY=/usr/bin/objcopy -DCMAKE_OBJDUMP=/usr/bin/objdump -DCMAKE_STRIP=/usr/bin/strip -DCMAKE_C_COMPILER=/sarc
  -c/compiler_tmp/tools/build/gcc-8.2.0/bin/gcc -DCMAKE_CXX_COMPILER=/tools/build/gcc-8.2.0/bin/g++ "-DCMAKE_C_FLAGS=-m64 " "-DCMAKE_CXX_FLAGS=-m64 " -DCMAKE_BUILD_TYPE=Relea
  se -DLLVM_PATH=/tmp/tmp.DxqFrKPwdj/src/llvm -DLLVM_BINARY_DIR=/tmp/tmp.DxqFrKPwdj/build/llvm/projects/compiler-rt/lib/fuzzer/libcxx_fuzzer_x86_64 -DLLVM_LIBRARY_OUTPUT_INTDIR=/tmp/tmp.DxqFrKPw
  dj/build/llvm/projects/compiler-rt/lib/fuzzer/libcxx_fuzzer_x86_64/lib -DCOMPILER_RT_LIBCXX_PATH=/tmp/tmp.DxqFrKPwdj/src/llvm/projects/libcxx -DCOMPILER_RT_LIBCXXABI_PATH=/tmp/tmp.DxqFrKPwdj/s
  rc/llvm/projects/libcxxabi -DCMAKE_CXX_COMPILER_WORKS=ON -DLIBCXX_ABI_NAMESPACE=Fuzzer -GNinja /tmp/tmp.DxqFrKPwdj/src/llvm/projects/compiler-rt/cmake/Modules/CustomLibcxx && /sarc-c/compiler_
  tmp/tools/build/cmake-3.13.4/bin/cmake -E touch /tmp/tmp.DxqFrKPwdj/build/llvm/projects/compiler-rt/lib/fuzzer/libcxx_fuzzer_x86_64-stamps//libcxx_fuzzer_x86_64-configure
  Re-run cmake no build system arguments
  -- The C compiler identification is GNU 8.2.0
  -- The CXX compiler identification is GNU 8.2.0
  ...

I am creating symlinks at the start of the build:

  cd "$BT_SRCD/llvm/tools"
  ln -s ../../polly
  ln -s ../../clang
  
  cd "$BT_SRCD/llvm/projects"
  ln -s "../../libcxx"
  ln -s "../../libcxxabi"
  ln -s "../../compiler-rt"

Are you possibly not building with `libcxx` and `libcxxabi`?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58184/new/

https://reviews.llvm.org/D58184