[PATCH] D56587: Introduce DW_OP_LLVM_convert

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 27 09:14:48 PST 2019


aprantl added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1947
+  for (auto &Op : Expr) {
+    if (Op.getCode() == dwarf::DW_OP_convert) {
+        Streamer.EmitInt8(Op.getCode(), Comment != End ? *(Comment++) : "");
----------------
Nice. Should we do the same thing as in dsymutil here and check for Encoding::BaseTypeRef?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56587/new/

https://reviews.llvm.org/D56587





More information about the llvm-commits mailing list