[PATCH] D58583: [X86][AVX] Pull out some INSERT_SUBVECTOR combines into a combineConcatVectorOps helper. NFCI

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 27 09:03:53 PST 2019


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:41791
 
+static SDValue combineConcatVectorOps(const SDLoc &DL, MVT VT, ArrayRef<SDValue> Ops,
+                                      SelectionDAG &DAG,
----------------
Should have a function-level comment to describe the intended usage. Ie, this can fold concat_vectors or the subvector operands in a chain of insert_subvectors.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58583/new/

https://reviews.llvm.org/D58583





More information about the llvm-commits mailing list