[PATCH] D58716: [llvm-readobj] - Fix the invalid dumping of the dynamic sections without terminating DT_NULL entry.

Wed Feb 27 08:00:14 PST 2019

grimar marked an inline comment as done.
grimar added inline comments.

================
Comment at: test/tools/llvm-readobj/elf-no-dtnull.s:4
+# RUN: yaml2obj -docnum=1 %s -o %t.o
+# RUN: llvm-readobj --dynamic-table %t.o | FileCheck %s
+
----------------
grimar wrote:
> jhenderson wrote:
> > I don't feel strongly about this, so if you don't want to that's fine, but as there is a chance of the GNU dumper diverging from the LLVM dumper here in the future (since the output is not all that GNU-like), I think you should test both styles.
> I have no problems with doing that. Done.
The output is the same atm so I did not introduce `LLVM` and `GNU` checks testing the same. I guess that is fine for that situation?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58716/new/

https://reviews.llvm.org/D58716