[PATCH] D53927: [AArch64] Enable libm vectorized functions via SLEEF

Wed Feb 27 05:06:16 PST 2019

steleman marked an inline comment as done.
steleman added a comment.

In D53927#1411714 <https://reviews.llvm.org/D53927#1411714>, @rengolin wrote:

>

>> Why does this come up now, after this changeset - and its friend D53928 <https://reviews.llvm.org/D53928> - have been reviewed for 4+ months, and already approved, and re-approved, and there are 21 subscribers to this changeset?
> 
> Again, another standard upstream behaviour (on Linux, GCC and others as well).
> 
> People are copied in all sorts of reviews, code owners even more. If we were to review everything that people copy us in straight away we wouldn't be able to do anything else, including our day jobs.
> 
> Matt's and Eric's comments here are very welcome, and I would appreciate their review on our comments about the design decisions. If they agree, we have more hope that this was the right thing all along. If they have more questions, proposals and change requests, we will be relieved that they caught something we didn't before users started relying on it.
> 
> It does take some time, but when it goes in, there's a higher probability of being right.
> 
> Given that this change (and its Clang counterpart) will add external user-visible behaviour that will have to be maintained for a long time, it's only right that more people chime in when they have time.
> 
> I'm glad Matt and Eric took the time before it went in.

Renato,

I don't have a problem with various people chiming in and offering comments and ideas.

I am, however, confused, about the concept of open-ended discussion that never reaches a terminal point, even though it would appear that it did.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53927/new/

https://reviews.llvm.org/D53927