[PATCH] D58707: [llvm-objdump] Should print strings when dumping DT_RPATH and DT_RUNPATH tags in dynamic section.

Xing via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 27 04:12:53 PST 2019


Higuoxing updated this revision to Diff 188518.
Higuoxing added a comment.
Herald added a subscriber: srhines.

Addressed @grimar and @jhenderson 's comments.

Thanks for the test file, I noticed that the last 5 d_tag are unknown. We should print them in hex format. I would like to resolve it in another 
patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58707/new/

https://reviews.llvm.org/D58707

Files:
  test/tools/llvm-objdump/elf-dynamic-section.test
  tools/llvm-objdump/ELFDump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58707.188518.patch
Type: text/x-patch
Size: 8071 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190227/0d48a028/attachment.bin>


More information about the llvm-commits mailing list