[PATCH] D58709: [llvm-objdump] - Improve the error message for "removing a section that is used by relocation" case.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 27 03:50:00 PST 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: MaskRay.

The message rubs me the wrong way slightly (not mentioning where the relocation itself is), but I think the information is probably sufficient, and I don't have any better suggestions, so LGTM. But please wait for @rupprecht too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58709/new/

https://reviews.llvm.org/D58709





More information about the llvm-commits mailing list