[PATCH] D58707: [llvm-objdump] Should print strings when dumping DT_RPATH and DT_RUNPATH tags in dynamic section.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D58707#1411723 <https://reviews.llvm.org/D58707#1411723>, @grimar wrote:

> > Only a small problem here, I have no idea on choosing test case. I see there's a test 
> >  file(test/tools/llvm-objdump/private-headers-dynamic-section.test). But it has no DT_RPATH and DT_RUNPATH tags. Shall I replace the ELF file in the 
> >  Inputs dir by a new one?
>
> Looking at that test, I think now we should be able to convert it to use yaml2obj instead of using the precompiled binary (as an independent change).


+1 to this. You could go as far as basically duplicating the test I've got for dynamic section tags in llvm-readobj in D58677 <https://reviews.llvm.org/D58677>. The only difference would be the output patterns to check. I //think// that test should give you what you are looking for. I'd make the test change first, so that the test starts failing (locally) after you have made your changes in this patch, before you update the test, if that makes sense.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58707/new/

https://reviews.llvm.org/D58707