[PATCH] D58572: [Support] allow -stats/-time-passes reporting into a custom stream

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

In D58572#1411712 <https://reviews.llvm.org/D58572#1411712>, @philip.pfaffe wrote:

> > This change is focused purely on the stream that LLVM uses to report the data being collected.
> >  No matter how many TimePassesHandlers you create (and yes, we do create TimePassesHandler one per thread-per-pipeline) they all emit into the same CreateInfoOutputFile() - either stderr or a single file.
> >  I'm trying to solve a problem of a badly interleaved output, thats all.
>
> You could set the output directly on the handler.


Do you suggest to get rid of the current scheme where we have a single output file for all kinds of "info data"?
Say, now w/o these changes -info-output-file is controlling the output file for both -stats and -time-passes.
Do you think it was a wrong design and we need to introduce separate output controls for each of those features?

Perhaps you can expand a bit on what exactly in *this* change do you see as problematic?
Your previous comment was mostly about overall -stats/-time-passes design, which I consider to be somewhat orthogonal here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58572/new/

https://reviews.llvm.org/D58572