[compiler-rt] r354718 - [NFC][Sanitizer] Comment out argument checks

[Vitaly Buka via llvm-commits]

it's better have no such commented code, if you remember about this, you
will know how to restore this checks anyway
if you forget, than it's just confusing noise for future readers
TODO is fine

On Tue, Feb 26, 2019 at 4:52 PM Julian Lettner <jlettner at apple.com> wrote:

> They broke the clang-ppc64 bots, but I don’t yet understand why.
> I want to re-enable them once the refactorings that ensure that we only
> call them with sane arguments are complete.
>
> > On Feb 26, 2019, at 4:30 PM, Vitaly Buka <vitalybuka at google.com> wrote:
> >
> > What is the point to keep them commented?
> >
> > On Fri, Feb 22, 2019 at 7:23 PM Julian Lettner via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
> > Author: yln
> > Date: Fri Feb 22 19:24:10 2019
> > New Revision: 354718
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=354718&view=rev
> > Log:
> > [NFC][Sanitizer] Comment out argument checks
> >
> > These break clang-ppc64 bots.
> >
> > Modified:
> >     compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc
> >     compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc
> >
> > Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc
> > URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc?rev=354718&r1=354717&r2=354718&view=diff
> >
> ==============================================================================
> > --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc
> (original)
> > +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc Fri
> Feb 22 19:24:10 2019
> > @@ -70,8 +70,8 @@ static inline uhwptr *GetCanonicFrame(up
> >
> >  void BufferedStackTrace::UnwindFast(uptr pc, uptr bp, uptr stack_top,
> >                                      uptr stack_bottom, u32 max_depth) {
> > -  CHECK_NE(stack_bottom, 0);
> > -  CHECK_GT(stack_top, stack_bottom);
> > +  // CHECK_NE(stack_bottom, 0);
> > +  // CHECK_GT(stack_top, stack_bottom);
> >    CHECK_GE(max_depth, 2);
> >    const uptr kPageSize = GetPageSizeCached();
> >    trace_buffer[0] = pc;
> >
> > Modified:
> compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc
> > URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc?rev=354718&r1=354717&r2=354718&view=diff
> >
> ==============================================================================
> > --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc
> (original)
> > +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc
> Fri Feb 22 19:24:10 2019
> > @@ -23,8 +23,8 @@ namespace __sanitizer {
> >
> >  void BufferedStackTrace::UnwindFast(uptr pc, uptr bp, uptr stack_top,
> >                                      uptr stack_bottom, u32 max_depth) {
> > -  CHECK_NE(stack_bottom, 0);
> > -  CHECK_GT(stack_top, stack_bottom);
> > +  // CHECK_NE(stack_bottom, 0);
> > +  // CHECK_GT(stack_top, stack_bottom);
> >    CHECK_GE(max_depth, 2);
> >    const uptr kPageSize = GetPageSizeCached();
> >    trace_buffer[0] = pc;
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190226/1e8af490/attachment.html>