[PATCH] D58701: [llvm-readobj] Print section type values for unknown sections.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 26 17:05:36 PST 2019


mattd added a comment.

In D58701#1411546 <https://reviews.llvm.org/D58701#1411546>, @Bigcheese wrote:

> lgtm
>
> Should the `+0` be `+0x0` so that it's //always// a hex digit?  Or is the `+0` what the binutils already output?


Thanks for the quick review!  GNU's readelf output's "+0" in this case, without the "0x" prefix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58701/new/

https://reviews.llvm.org/D58701





More information about the llvm-commits mailing list