[PATCH] D57541: [DAGCombiner] Eliminate dead stores to stack.

[Nirav Davé via llvm-commits]

Wait. Scratch that. This is not GatherAllAliases. I keep making that
mistake.

That said there is a potential regression from lifetime nodes because they
can form an artificial dependence between ops before and after it.

On Tue, Feb 26, 2019, 16:28 Nirav Dave via Phabricator <
reviews at reviews.llvm.org> wrote:

> niravd added inline comments.
>
>
> ================
> Comment at: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15524
> +        Chains.push_back(Chain.getOperand(0));
> +      }
> +      break;
> ----------------
> Ahha! We never add the lifetime to the Alias list like we should if we
> dont' skip past it. I suspect this is why we had to revert this patch.
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D57541/new/
>
> https://reviews.llvm.org/D57541
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190226/6474df89/attachment.html>