[PATCH] D58696: [NFC][Sanitizer] Cleanup GetStackTrace implementations

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 26 13:14:14 PST 2019


yln created this revision.
Herald added subscribers: llvm-commits, Sanitizers, kubamracek.
Herald added projects: Sanitizers, LLVM.
yln added a parent revision: D58657: [NFC][Sanitizer] Always use GetStackTrace to fill in stack.
yln added a reviewer: vitalybuka.

GetStackTrace implementations seem to have started out as exact copies
of the original implementation in ASan, but have diverged in subtle
ways. I left comments for these differences and will address them
according to your guidance in a follow-up patch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D58696

Files:
  compiler-rt/lib/asan/asan_stack.cc
  compiler-rt/lib/hwasan/hwasan.cc
  compiler-rt/lib/lsan/lsan.cc
  compiler-rt/lib/msan/msan.cc
  compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58696.188449.patch
Type: text/x-patch
Size: 9337 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190226/584cd92c/attachment.bin>


More information about the llvm-commits mailing list