[PATCH] D58686: [scudo][standalone] Adding vector, bytemap & stats

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/scudo/standalone/CMakeLists.txt:44
+  bytemap.h
+  internal_defs.h
+  linux.h
----------------
This patch should be 3 patches.


================
Comment at: lib/scudo/standalone/bytemap.h:58
+    memset(Level1Map, 0, sizeof(atomic_uptr) * Level1Size);
+  }
+
----------------
I assume this is mostly fork from sanitizer_common.
I do not insists, but it would be nice to do that it two steps:
1. Patch with unmodified copy (maybe single large patch for all files used in standalone version) so that fabricator shows this as a copy
2. Patch with changes


================
Comment at: lib/scudo/standalone/vector.h:20
+// small vectors. The current implementation supports only POD types.
+template <typename T> class VectorNoCtor {
+public:
----------------
have you considered to use std::vector with custom allocator?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58686/new/

https://reviews.llvm.org/D58686