[PATCH] D58385: [tools] Rewrite tests for symbol remapping to FileCheck

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D58385#1410534 <https://reviews.llvm.org/D58385#1410534>, @Hahnfeld wrote:

> In D58385#1410520 <https://reviews.llvm.org/D58385#1410520>, @lebedev.ri wrote:
>
> > In D58385#1410516 <https://reviews.llvm.org/D58385#1410516>, @Hahnfeld wrote:
> >
> > > Ping, that's now the only test that fails the `reverse-iteration` bot...
> >
> >
> > This seems to only shuffle the tests around.
> >  Does this now pass in reverse-iteration config?
>
>
> Yes, I've tested this locally. The idea for `instr-remap.test` is to invoke `FileCheck` three times, checking each function separately.


So then i think i'm missing the point..

If it currently passes without reverse iteration, and does not pass with reverse iteration, 
then that means there is some nondeterminism, correct?
So why is **silencing** this determinism via modifying the tests is the correct thing to do?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58385/new/

https://reviews.llvm.org/D58385