[PATCH] D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces.

[Alexey Lapshin via Phabricator via llvm-commits]

alexey.lapshin marked 8 inline comments as done.
alexey.lapshin added inline comments.


================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:206
+
+  if (error(BinaryOrErr))
+    return object::SectionedAddress::UndefSection;
----------------
dblaikie wrote:
> can't say I've seen this written this way - I think it's probably more common to write it as "if (!BinaryOrErr)"?
There are more usages of error() in this file. so I did it exactly like in other places. Though if you think it would be better to change it into "if (!BinaryOrErr)" then I will change it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58194/new/

https://reviews.llvm.org/D58194