[PATCH] D58667: [yaml2obj][obj2yaml] - Add support for the architecture specific dynamic tags.

Tue Feb 26 05:00:05 PST 2019

grimar added a comment.

In D58667#1410401 <https://reviews.llvm.org/D58667#1410401>, @jhenderson wrote:

> It's like you read my mind. I'm literally in the middle of writing an llvm-readobj test for dynamic tag dumping!

No magic here this time, don't worry :) I was who introduced that "TODO" in the code which is now removed by this patch. Just finishing started.

================
Comment at: test/tools/obj2yaml/dynamic-section-arch-tags.test:115-116
+    Entries:
+      - Tag:             DT_NULL
+        Value:           0x0000000000000000
+      - Tag:             DT_MIPS_RLD_VERSION
----------------
jhenderson wrote:
> I don't think you need the DT_NULL tags either?
I included it because it is a mandatory field basing on ELF spec.
Though probably for this test it is not important to have it. I removed it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58667/new/

https://reviews.llvm.org/D58667