[PATCH] D58651: [NFC][Sanitizer] Pull up GetStackTrace into sanitizer_common

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 25 16:21:45 PST 2019


yln created this revision.
yln added a reviewer: vitalybuka.
Herald added subscribers: llvm-commits, Sanitizers, kubamracek.
Herald added projects: Sanitizers, LLVM.

We already independently declare GetStackTrace in all (except TSan)
sanitizer runtime headers. Lets move it to sanitizer_stacktrace.h to
have one canonical way to fill in a BufferedStackFrame. Also enables us
to use it in sanitizer_common itself.

This patch defines GetStackTrace for TSan and moves the function from
ubsan_diag.cc to ubsan_diag_standalone.cc to avoid duplicate symbols
for the UBSan-ASan runtime.

Other than that this patch just moves the code out of headers and into
the correct namespace.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D58651

Files:
  compiler-rt/lib/asan/asan_stack.cc
  compiler-rt/lib/asan/asan_stack.h
  compiler-rt/lib/hwasan/hwasan.cc
  compiler-rt/lib/hwasan/hwasan.h
  compiler-rt/lib/lsan/lsan.cc
  compiler-rt/lib/lsan/lsan.h
  compiler-rt/lib/msan/msan.cc
  compiler-rt/lib/msan/msan.h
  compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.h
  compiler-rt/lib/tsan/rtl/tsan_stack_trace.cc
  compiler-rt/lib/ubsan/ubsan_diag.cc
  compiler-rt/lib/ubsan/ubsan_diag.h
  compiler-rt/lib/ubsan/ubsan_diag_standalone.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58651.188270.patch
Type: text/x-patch
Size: 14033 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190226/72412ca4/attachment.bin>


More information about the llvm-commits mailing list