[PATCH] D58635: AMDGPU: Remove IntrReadMem from memtime/memrealtime intrinsics

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SMInstructions.td:160
+
+  // FIXME: This should be definitively mayStore = 0.
+  let mayStore = ?;
----------------
arsenm wrote:
> rampitec wrote:
> > It was zero before this patch.
> This is to defeat tablegen's completely broken inference of instruction flags based on intrinsic properties. This conflicts with the assumed mayStore since the intrinsic isn't IntrReadMem. The assumption the flags directly correspond to the intrinsic attributes is broken because the weird memory dependency is tracked here with hasSideEffects. It's even more broken because this was working with readcyclecounter already, since it isn't a target intrinsic.
At the very least it needs a comment explaining why is it '?'.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58635/new/

https://reviews.llvm.org/D58635