[PATCH] D58580: [Support] llvm::to_string(): raw_string_ostream is a memory hog

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 25 11:02:56 PST 2019


lebedev.ri added a comment.

In D58580#1409395 <https://reviews.llvm.org/D58580#1409395>, @rnk wrote:

> `operator<<` does this internally, see `write_unsigned_impl`. Instead of doing this, let's just disable buffering in raw_string_ostream. We already do it in raw_svector_ostream.


I can do that, but i don't think i will be able to do any benchmarks. Will that change be ok as-is?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58580/new/

https://reviews.llvm.org/D58580





More information about the llvm-commits mailing list