[PATCH] D58635: AMDGPU: Remove IntrReadMem from memtime/memrealtime intrinsics

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec requested changes to this revision.
rampitec added a comment.
This revision now requires changes to proceed.

1. These intrinsics read internal state. If not IntrReadMem something needs to be added to model it.
2. Patch does more than stated in the description with no justification.



================
Comment at: lib/Target/AMDGPU/SMInstructions.td:160
+
+  // FIXME: This should be definitively mayStore = 0.
+  let mayStore = ?;
----------------
It was zero before this patch.


================
Comment at: lib/Target/AMDGPU/SMInstructions.td:797
 
+def : GCNPat <
+  (i64 (int_amdgcn_s_memrealtime)),
----------------
It does not belong to the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58635/new/

https://reviews.llvm.org/D58635