[PATCH] D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 25 07:49:48 PST 2019


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one remaining nit.



================
Comment at: test/tools/llvm-objcopy/ELF/change-entry-point.test:31
+
+# The --adjust-start is an alias for --change-start.
+# RUN: llvm-objcopy --adjust-start -0x1101 %t %t13
----------------
You don't need the "The" here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58173/new/

https://reviews.llvm.org/D58173





More information about the llvm-commits mailing list