[PATCH] D54697: [llvm-objdump] Add `Version References` dumper

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 25 00:53:11 PST 2019


grimar added inline comments.


================
Comment at: tools/llvm-objdump/ELFDump.cpp:313
+        Shdr.sh_type != ELF::SHT_GNU_verneed)
+      continue;
+
----------------
grimar wrote:
> If you're not going to implement `SHT_GNU_verneed` in this patch then I think you should
> get rid of `Shdr.sh_type != ELF::SHT_GNU_verneed`.
I meant "if you're not going to implement `ELF::SHT_GNU_verdef`" of course..


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54697/new/

https://reviews.llvm.org/D54697





More information about the llvm-commits mailing list