[PATCH] D58584: [XRay][tools] Revert "Use Support/JSON.h in llvm-xray convert"

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 24 13:54:02 PST 2019


lebedev.ri added a comment.

In D58584#1408350 <https://reviews.llvm.org/D58584#1408350>, @dberris wrote:

> LGTM -- thanks!


Thank you. Will land later today.

> What I wish existed was a stateful JSON output stream implementation instead of the build-everything-in-memory model. Maybe someday. :)

Yeah. LLVM's YAML library is that way.
I did try to bend it to my will and produce [identical] JSON, but did not really succeed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58584/new/

https://reviews.llvm.org/D58584





More information about the llvm-commits mailing list