[compiler-rt] r354718 - [NFC][Sanitizer] Comment out argument checks

Julian Lettner via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 22 19:24:10 PST 2019


Author: yln
Date: Fri Feb 22 19:24:10 2019
New Revision: 354718

URL: http://llvm.org/viewvc/llvm-project?rev=354718&view=rev
Log:
[NFC][Sanitizer] Comment out argument checks

These break clang-ppc64 bots.

Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc?rev=354718&r1=354717&r2=354718&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc Fri Feb 22 19:24:10 2019
@@ -70,8 +70,8 @@ static inline uhwptr *GetCanonicFrame(up
 
 void BufferedStackTrace::UnwindFast(uptr pc, uptr bp, uptr stack_top,
                                     uptr stack_bottom, u32 max_depth) {
-  CHECK_NE(stack_bottom, 0);
-  CHECK_GT(stack_top, stack_bottom);
+  // CHECK_NE(stack_bottom, 0);
+  // CHECK_GT(stack_top, stack_bottom);
   CHECK_GE(max_depth, 2);
   const uptr kPageSize = GetPageSizeCached();
   trace_buffer[0] = pc;

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc?rev=354718&r1=354717&r2=354718&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc Fri Feb 22 19:24:10 2019
@@ -23,8 +23,8 @@ namespace __sanitizer {
 
 void BufferedStackTrace::UnwindFast(uptr pc, uptr bp, uptr stack_top,
                                     uptr stack_bottom, u32 max_depth) {
-  CHECK_NE(stack_bottom, 0);
-  CHECK_GT(stack_top, stack_bottom);
+  // CHECK_NE(stack_bottom, 0);
+  // CHECK_GT(stack_top, stack_bottom);
   CHECK_GE(max_depth, 2);
   const uptr kPageSize = GetPageSizeCached();
   trace_buffer[0] = pc;




More information about the llvm-commits mailing list