[PATCH] D55283: CodeGen: Refactor regallocator command line and target selection

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM, one last nitpick below.



================
Comment at: lib/CodeGen/TargetPassConfig.cpp:1106
+  // Allow targets to change the register assignments before rewriting.
+  addPreRewrite();
+
----------------
Add a comment on the declaration of addPreRewrite that it may not be honored if the target overloads addRegAssignAndRewriteOptimized or more generally doesn't actually have two distinct passes (e.g., the fast variant wouldn't call into addPreRewrite).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55283/new/

https://reviews.llvm.org/D55283