[PATCH] D58472: [WebAssembly] Remove unneeded MCSymbolRefExpr variants

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 22 11:37:51 PST 2019


dschuff added a comment.

IIRC this code goes back to when we were piggybacking on ELF, and is more-or-less there to match how those variants are used on ELF. I don't see any asm parser changes in this CL, but I could imagine that they would exist so that the assembler could know what kind of reloc to use even without any context or special knowledge of symbol types; does this change affect how asm is parsed? Maybe we've already added enough extra intelligence to the assembler that we don't need them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58472/new/

https://reviews.llvm.org/D58472





More information about the llvm-commits mailing list