[PATCH] D58499: [CommandLine] Do not crash if an option has both ValueRequired and Grouping.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 22 09:09:25 PST 2019


ikudrin added a comment.

In D58499#1405561 <https://reviews.llvm.org/D58499#1405561>, @jhenderson wrote:

> What happens for ValueOptional? I want to make sure that it doesn't treat the other grouped letters after it as the option's value.


As far as I can see, in case of grouped options, the value might be assigned only if it is a prefixed option. Did you mean a specific case? Could you provide it so that I understand you better?

Anyway, if anything needs fixing with `ValueOptional`, it should be a separate patch, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58499/new/

https://reviews.llvm.org/D58499





More information about the llvm-commits mailing list