[PATCH] D58510: [yaml2obj]Allow explicit symbol indexes in relocations and emit error for bad names

[James Henderson via Phabricator via llvm-commits]

jhenderson marked 5 inline comments as done.
jhenderson added inline comments.


================
Comment at: test/tools/yaml2obj/relocation-explicit-symbol-index.yaml:2
+# Test that a relocation's symbol can be an integer.
+# RUN: yaml2obj --docnum=1 %s > %t
+# LLVM tools (both llvm-readobj and llvm-objdump) reject relocations with
----------------
grimar wrote:
> Do you need --docnum?
No, that was left over from a previous version of this test.


================
Comment at: test/tools/yaml2obj/relocation-explicit-symbol-index.yaml:10
+# CHECK-NEXT: 0x00000010 00000000 00000000 00000000 00000000
+# CHECK-NEXT: 0x00000020 02000000 01000000 00000000 00000000
+
----------------
grimar wrote:
> I would suggest doing something like we have in LLD tests here to show the values
> you want to pay attention to explicitly. e.g.:
> 
> ```
> # CHECK-NEXT:     0000: 011B033B 1C000000 02000000 A80E0000
> ##                               ^        ^-- FDE(1) PC
> ##                               ^-- Number of FDEs
> # CHECK-NEXT:     0010: 38000000 AA0E0000 50000000
> ##                               ^-- FDE(2) PC
> ```
> 
> Up to you though.
I like that idea, thanks.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58510/new/

https://reviews.llvm.org/D58510