[PATCH] D58535: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 21 17:26:42 PST 2019


thegameg created this revision.
thegameg added reviewers: paquette, anemet, JDevlieghere, deadalnix, hfinkel, fhahn.
Herald added subscribers: jdoerfert, dexonsmith, steven_wu, hiraditya, javed.absar, mgorny, mehdi_amini.
Herald added a project: LLVM.

Getting rid of the name "optimization remarks" for anything that involves emitting YAML and parsing remarks.

It's safer to do this now, before we get stuck with that name in all the APIs and public interfaces we decide to export to users in the future.

This renames llvm/tools/opt-remarks to llvm/tools/remarks-shlib, and now generates `libRemarks.dylib` instead of `libOptRemarks.dylib`.


https://reviews.llvm.org/D58535

Files:
  clang/include/clang/Basic/CodeGenOptions.h
  clang/lib/CodeGen/BackendUtil.cpp
  clang/lib/CodeGen/CodeGenAction.cpp
  clang/lib/Driver/ToolChains/Darwin.cpp
  clang/lib/Frontend/CompilerInvocation.cpp
  llvm/cmake/modules/AddLLVM.cmake
  llvm/include/llvm-c/OptRemarks.h
  llvm/include/llvm-c/Remarks.h
  llvm/include/llvm/CodeGen/MachineOptimizationRemarkEmitter.h
  llvm/include/llvm/IR/DiagnosticHandler.h
  llvm/lib/CMakeLists.txt
  llvm/lib/IR/DiagnosticHandler.cpp
  llvm/lib/IR/DiagnosticInfo.cpp
  llvm/lib/LLVMBuild.txt
  llvm/lib/OptRemarks/CMakeLists.txt
  llvm/lib/OptRemarks/LLVMBuild.txt
  llvm/lib/OptRemarks/OptRemarksParser.cpp
  llvm/lib/Remarks/CMakeLists.txt
  llvm/lib/Remarks/LLVMBuild.txt
  llvm/lib/Remarks/RemarkParser.cpp
  llvm/lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp
  llvm/test/tools/gold/X86/opt-remarks.ll
  llvm/tools/gold/gold-plugin.cpp
  llvm/tools/llvm-lto2/llvm-lto2.cpp
  llvm/tools/llvm-opt-report/CMakeLists.txt
  llvm/tools/llvm-opt-report/OptReport.cpp
  llvm/tools/opt-remarks/CMakeLists.txt
  llvm/tools/opt-remarks/OptRemarks.exports
  llvm/tools/opt-remarks/liboptremarks.cpp
  llvm/tools/opt/NewPMDriver.cpp
  llvm/tools/opt/NewPMDriver.h
  llvm/tools/opt/opt.cpp
  llvm/tools/remarks-shlib/CMakeLists.txt
  llvm/tools/remarks-shlib/Remarks.exports
  llvm/tools/remarks-shlib/libremarks.cpp
  llvm/unittests/CMakeLists.txt
  llvm/unittests/OptRemarks/CMakeLists.txt
  llvm/unittests/Remarks/CMakeLists.txt
  llvm/unittests/Remarks/RemarksParsingTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58535.187891.patch
Type: text/x-patch
Size: 58575 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190222/d41b54e3/attachment.bin>


More information about the llvm-commits mailing list