[PATCH] D58044: [DwarfDebug] Dump call site debug info into DWARF

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:1214
+      addDIEEntry(CSDie, dwarf::DW_AT_abstract_origin, *CalledDIE);
+    // TODO: DW_AT_call_origin is DWARF5 replacement of abstract_origin
+  } else {
----------------
probinson wrote:
> vsk wrote:
> > Any chance to share code with DwarfCompileUnit::constructCallSiteEntryDIE?
> I don't understand this comment.  DW_AT_call_origin is for the call-site stuff, DW_AT_abstract_origin is for inlined instances.  call_origin is not a "replacement" for abstract_origin.
Sorry, didn't mean to conflate abstract_origin vs. call_origin here. What I'm getting at is that DwarfCompileUnit::constructCallSiteDIE and the pre-existing constructCallSiteEntryDIE both do some work at each call site. I'm just wondering if it's feasible to have one entry point for that sort of work.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58044/new/

https://reviews.llvm.org/D58044