[PATCH] D58413: [sanitizers] Restore internal_readlink for x32

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D58413#1406000 <https://reviews.llvm.org/D58413#1406000>, @morehouse wrote:

> @rnk:  Could you help out here?  I am clueless with Windows.


The answer is very straightforward, this code in sanitizer_win.cc:

  uptr ReadBinaryName(/*out*/char *buf, uptr buf_len) {
    // FIXME: Actually implement this function.
    CHECK_GT(buf_len, 0);
    buf[0] = 0;
    return 0;
  }

Of course the test fails, this always returns 0. Recommitting with the test disabled on Windows seems reasonable.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58413/new/

https://reviews.llvm.org/D58413