[PATCH] D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 21 05:18:45 PST 2019


jmorse marked 2 inline comments as done.
jmorse added inline comments.


================
Comment at: lib/CodeGen/MachineSink.cpp:788
+
+    if (MI.isCopy()) {
+      bool DoCopy = false;
----------------
NikolaPrica wrote:
> TargetInstrInfo::isCopyInstr here? It should support pseudo COPY instruction and target specific register copy instructions.
Sounds good, updated test to call isCopyInstr.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58238/new/

https://reviews.llvm.org/D58238





More information about the llvm-commits mailing list